New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update onChange/input events fired on selected option #370
fix: update onChange/input events fired on selected option #370
Conversation
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 385 385
Branches 111 111
=========================================
Hits 385 385
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just have a minor code style note.
01bd560
to
8fadc71
Compare
Thanks for your reviews, I appreciate that 😄 . I have fixed what was wrong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coolio 👍👍
@nickmccurdy, I'll let you merge this one. You should be able to once the build is successful. Just make sure to use squash and merge and follow the commit message convention so we get the right release for it (I think it should be good without change actually). Actually you'll want to add the text "Closes #358" somewhere in the body of the commit to semantic release will add a release comment to that issue. Thanks! |
541c2ee
to
d757b47
Compare
Will this fix this issue where Or should I create a separate bug? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Thanks!
@fabb, I don't know. Can you try when this is released? |
Hey @marcosvega91, you've been added as an official member of the GitHub org :) Thanks for all you do! |
🎉 This PR is included in version 12.0.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Thank you @kentcdodds. I don't have other words, I started to contribute some months ago after one of your tweets and now I'm a member of testing lib. I discovered a world and I'm learning a lot thanks to you. Thank you for this opportunity and for your trust 🎉 Regards |
@kentcdodds yes, it's fixed, thanks! |
fix #358
What:
This PR will fix the issue that events (onChage/input) are not fired on ancestors.
This issue was related to a problem with React because it fires event on bubbling phase.
As we can see from the images below
the change event is an
Event
of typechange
the input event is an
Event
of typeinput
Both events are of a generic event type.
Why:
Because in particular with React the change event is fired but the onChange listener didn't work
How:
By calling
Checklist: